Conversation
teja2
requested review from
adolgachev and
crisbeto
and removed request for
a team
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
src/cdk/table/table.ts
Outdated
| * `multiTemplateDataRows` or adding/removing row definitions. | ||
| */ | ||
| private _forceRenderDataRows() { | ||
| this._viewRepeater.detach(); |
There was a problem hiding this comment.
It looks like this breaks some tests. Also my impression is that detach is only meant to be called once.
|
@crisbeto updated the PR. Added a clearCache hook to _RecycleViewRepeaterStrategy and switched CdkTable’s forced re-render path to call it so recycled rows are flushed without repeatedly tearing down the entire repeater. |
|
Fixed the tests as well |
|
It looks like the tests are still failing. Also CLA isn't signed. |
|
@crisbeto can you please now. locally it is passing |
2 participants
No description provided.